Fixed double comment sanitation.
authorDylan Lloyd <dylan@miniscule.localdomain>
Mon, 12 Dec 2011 16:58:05 +0000 (11:58 -0500)
committerDylan Lloyd <dylan@miniscule.localdomain>
Mon, 12 Dec 2011 16:58:05 +0000 (11:58 -0500)
Now ONLY sanitizing output. Input is safe for mysql with bound parameters.

index.php

index 88f82d2..485b063 100644 (file)
--- a/index.php
+++ b/index.php
@@ -435,8 +435,8 @@ class note extends cms {
       // and a default author needs to be set
       // for no-javascript users.
       $stmt->bind_param('sss',
-                          htmlspecialchars($_POST['name']),
-                          htmlspecialchars($_POST['text']),
+                          $_POST['name'],
+                          $_POST['text'],
                         $this->id);
       $stmt->execute();
     }
@@ -491,7 +491,7 @@ END_OF_NAVIGATION;
       $date_posted = $entry['date_posted'];
       $author = $entry['author'];
       $text = htmlspecialchars($entry['text']);
-      $head = "<h3>$author</h3>";
+      $head = "<h3>" . htmlspecialchars($author) . "</h3>";
       echo <<<END_OF_COMMENT
       <div class='comment'>
       $head